Skip to content

Commit

Permalink
editor/sagas: disable code completion trigger on space
Browse files Browse the repository at this point in the history
This gets in the way when typing comments and often results in
accepting a completion that was not intended.

Fixes: pybricks/support#894
  • Loading branch information
dlech committed Dec 30, 2022
1 parent 7d5c971 commit 62d7fdf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
## [Unreleased]

### Changed
- Code completion trigger improvements.
- Code completion trigger improvements ([support#894]).

### Fixed
- Fixed terminal layout issues when resizing window vertically.
- Fixed editor find widget visible over modal dialogs.

[support#894]: https://github.com/pybricks/support/issues/894

## [2.1.0-beta.3] - 2022-12-28

### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/editor/sagas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ function* runJedi(): Generator {
const subscription = monaco.languages.registerCompletionItemProvider(
pybricksMicroPythonId,
{
triggerCharacters: ['.', ' '],
triggerCharacters: ['.'],
provideCompletionItems(
model,
position,
Expand Down

0 comments on commit 62d7fdf

Please sign in to comment.