Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloaderInstructions: add videos #1364

Merged
merged 1 commit into from
Dec 9, 2022
Merged

bootloaderInstructions: add videos #1364

merged 1 commit into from
Dec 9, 2022

Conversation

dlech
Copy link
Member

@dlech dlech commented Dec 9, 2022

This adds videos to show how to enter bootloader mode.

Issue: pybricks/support#728

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 69.99% // Head: 69.58% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (9a28383) compared to base (ec06b00).
Patch coverage: 60.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   69.99%   69.58%   -0.41%     
==========================================
  Files         189      189              
  Lines        4539     4666     +127     
  Branches      913      948      +35     
==========================================
+ Hits         3177     3247      +70     
- Misses       1342     1402      +60     
+ Partials       20       17       -3     
Impacted Files Coverage Δ
src/blueprintjs-icons.js 0.00% <ø> (ø)
src/components/ViewHeightSensor.tsx 50.00% <ø> (ø)
src/editor/lib.ts 100.00% <ø> (ø)
src/editor/pybricksMicroPython.ts 47.61% <ø> (ø)
src/editor/sagas.ts 37.63% <ø> (ø)
src/editor/untitledHint.ts 97.22% <ø> (ø)
src/fileStorage/actions.ts 100.00% <ø> (ø)
src/fileStorage/index.ts 100.00% <ø> (ø)
src/index.tsx 0.00% <ø> (ø)
src/settings/Settings.tsx 75.00% <0.00%> (-6.40%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@laurensvalk
Copy link
Member

laurensvalk commented Dec 9, 2022

I could try looking at the details later tonight (not in the next hour), but if you’re happy with how it looks I’m all 🟢 for a beta/RC release.

We can tweak the videos and text next week as needed.

This adds videos to show how to enter bootloader mode.

Issue: pybricks/support#728
@dlech dlech enabled auto-merge (rebase) December 9, 2022 19:14
@dlech dlech merged commit 0f871c6 into master Dec 9, 2022
@dlech dlech deleted the dlech branch December 9, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants