Filter RSSI, add signal_strength method #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have an explicit set of channels to observe, it makes sense to start observing when the class is initialized, instead of starting to scan all channels when calling observe on channel X.
Now that the RSSI is filtered, it no longer belongs to a particular observe event, so there is no benefit of returning it from the same method. This simplifies the observe method to deal only with data, so it is a bit closer to what the broadcast is doing.
This modifies ble.observe() to return None if no data has been observed yet or there has been a time out since the last received data. This way there is an unambiguous way to check for valid data.
|
Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed improvement to #158.
The RSSI value is quite jittery. This filters the signal to be smoother. It takes the time between samples into account, so that there is no filter delay to register the first valid RSSI value.
The
rssivalue gets its ownsignal_strengthmethod. Rationale:Received Signal Strength Indicatoris a bit long so I went withsignal_strength. However, since it is a separate method for more advanced users, I'm not opposed to calling it justrssi.