Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] example motor_until_stalled_center.py does not center the steering (it is not in the program) #734

Closed
BertLindeman opened this issue Oct 8, 2022 · 3 comments · Fixed by pybricks/pybricks-api#112
Closed

[Bug] example motor_until_stalled_center.py does not center the steering (it is not in the program) #734

BertLindeman opened this issue Oct 8, 2022 · 3 comments · Fixed by pybricks/pybricks-api#112
Assignees
@laurensvalk
Labels
bug Something isn't working documentation Improvements or additions to documentation topic: motors Issues involving motors
Projects
Pybricks v3.2

Comments

@BertLindeman
Copy link

In beta.pybricks.com looked at the doc (v3.2) for an example to center the steering of a model.
Surprised that the examples/pup/motor/motor_until_stalled_center.py does not do the centering.

The examples motor_until_stalled_center.py and motor_until_stalled.py are the same.

In code.pybricks.com these examples are also the same in the doc (v3.1).

Maybe the original example (I thought is WAS there) got lost?
@dlech dlech added the documentation Improvements or additions to documentation label Oct 8, 2022
@laurensvalk laurensvalk added bug Something isn't working topic: motors Issues involving motors labels Oct 8, 2022
@dlech dlech added this to To do in Pybricks v3.2 via automation Oct 8, 2022
@laurensvalk
Copy link
Member

laurensvalk commented Oct 8, 2022 •
edited
Loading

This is related to #729, but there is also an additional bug that I'm in the process of fixing.

As a workaround, try the (latest) firmware given in #729, and additionally add a stop() call in between successive run_until_stalled calls.

Sounds like we need to fix the example as well.

Thanks for reporting!

@laurensvalk laurensvalk added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 8, 2022
dlech added a commit to pybricks/pybricks-api that referenced this issue Oct 8, 2022
@dlech
doc/main/pupdevices/motor: Fix center example.
0fc9c16 
This fixes the include for the centering example to link it to the correct source file.

Fixes: pybricks/support#734 (comment)
@dlech dlech mentioned this issue Oct 8, 2022
Merged
Pybricks v3.2 automation moved this from To do to Done Oct 10, 2022
laurensvalk pushed a commit to pybricks/pybricks-api that referenced this issue Oct 10, 2022
@dlech @laurensvalk
doc/main/pupdevices/motor: Fix center example.
96be47f 
This fixes the include for the centering example to link it to the correct source file.

Fixes: pybricks/support#734 (comment)
@laurensvalk
Copy link
Member

The docs are fixed but the firmware is not, so re-open.

@laurensvalk laurensvalk reopened this Oct 10, 2022
Pybricks v3.2 automation moved this from Done to In progress Oct 10, 2022
@laurensvalk laurensvalk self-assigned this Oct 10, 2022
@laurensvalk
Copy link
Member

The docs are fixed but the firmware is not, so re-open.

This is fixed --- the example now runs on the latest firmware again.

Pybricks v3.2 automation moved this from In progress to Done Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurensvalk laurensvalk

Labels
bug Something isn't working documentation Improvements or additions to documentation topic: motors Issues involving motors
Projects
Pybricks v3.2
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc/main/pupdevices/motor: Fix center example. pybricks/pybricks-api
3 participants
@dlech @BertLindeman @laurensvalk