Merge pull request #405 from arcivanov/issue_404

Wrong dependency version error formatting
pybuilder · Sep 19, 2016 · 3884446 · 3884446
2 parents 3484502 + 9548461
commit 3884446
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/python/pybuilder/core.py b/src/main/python/pybuilder/core.py
@@ -239,7 +239,7 @@ def __init__(self, name, version=None, url=None):
                 try:
                     version = str(SpecifierSet(version))
                 except InvalidSpecifier:
-                    raise ValueError("'%s' must be either PEP 0440 version or a version specifier set")
+                    raise ValueError("'%s' must be either PEP 0440 version or a version specifier set" % version)
 
         self.version = version
         self.url = url

diff --git a/src/unittest/python/plugins/python/install_dependencies_plugin_tests.py b/src/unittest/python/plugins/python/install_dependencies_plugin_tests.py
@@ -204,6 +204,9 @@ def test_should_install_dependency_with_version_and_operator(self, exec_command,
         exec_command(
             PIP_EXEC_STANZA + ["install", 'spam==0.1.2'], ANY, env=ANY, shell=False)
 
+    def test_should_install_dependency_with_wrong_version_and_operator(self):
+        self.assertRaises(ValueError, Dependency, "spam", "~=1")
+
     @patch("pybuilder.plugins.python.install_dependencies_plugin.create_constraint_file")
     @patch("pybuilder.plugins.python.install_dependencies_plugin.get_package_version", return_value={})
     @patch("pybuilder.plugins.python.install_dependencies_plugin.execute_command", return_value=0)