Rollback to pyo3 = { version = "0.16.6", features = ["abi3"] }
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Jan 3, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
rm -rf ../python*-bcrypt*4.1.1*.*
See pyca#695
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Jan 3, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
rm -rf ../python*-bcrypt*4.1.2*.*
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Jan 3, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
rm -rf ../python*-bcrypt*4.1.2*.*
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Jan 3, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
rm -rf ../python*-bcrypt*4.1.1*.*
See pyca#695
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
This does not actually fix the issue, it merely removes the error -- pyo3 modules still do not support sub-interpreters. |
|
Yes this PR doesn't solve the problem but just rolling back as original behavior... BTW I couldn't see any schedule for PyO3/pyo3#576 getting done... If we don't really depends on features provided by pyo3 >= 0.17.0, at least this PR will not block the use of bcrypt on Ceph... |
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Feb 24, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
rm -rf ../python*-bcrypt*4.1.1*.*
See pyca#695
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
Feb 24, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
rm -rf ../python*-bcrypt*4.1.2*.*
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pyca-bcrypt
that referenced
this pull request
May 4, 2024
git clean -xdf
mkdir -p .cargo
cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
tar zcvf ../python-bcrypt_4.1.3.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-bcrypt.spec ../python-bcrypt_4.1.3-1.spec
cp ../python*-bcrypt*4.1.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.3/
rm -rf ../python*-bcrypt*4.1.3*.*
See pyca#714
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
In order to avoid `ImportError: PyO3 modules compiled for CPython 3.8 or older may only be initialized once per interpreter process` introduced since pyo3 >= 0.17.0, which only allow each `#[pymodule]` to be initialized once, this PR temporarily rollback to pyo3 = 0.16.6. It also remove the use of `PyUserWarning` which introduced since pyo3 > 0.18.0. See PyO3/pyo3@78ba70d See PyO3/pyo3@1d20f2a Fixes pyca#694 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
Still, this is not a good idea for rollback; but well, PyO3/pyo3#576 have no progress as expected... So at least an update for 4.1.3 + force push for this PR, used with my: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid
ImportError: PyO3 modules compiled for CPython 3.8 or older may only be initialized once per interpreter processintroduced since pyo3 >= 0.17.0, which only allow each#[pymodule]to be initialized once, this PR temporarily rollback to pyo3 = 0.16.6.It also remove the use of
PyUserWarningwhich introduced since pyo3 > 0.18.0.See PyO3/pyo3@78ba70d
See PyO3/pyo3@1d20f2a
Fixes #694