Reorder link-time library search path #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putting bundled libsodium lib directory first
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 36 36
Lines 1418 1418
Branches 69 69
=======================================
Hits 1416 1416
Misses 1 1
Partials 1 1Continue to review full report at Codecov.
|
|
@dstufft would you mind taking a look at this small change? |
|
LGTM. This path is only used if we're not trying to use the system libs, so our copy should definitely be prioritized. |
lmctv
added a commit
to lmctv/pynacl
that referenced
this pull request
Mar 31, 2017
putting bundled libsodium lib directory first
reaperhulk
pushed a commit
that referenced
this pull request
Mar 31, 2017
lmctv
added a commit
to lmctv/pynacl
that referenced
this pull request
Mar 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putting bundled libsodium lib directory first.
Confirmed by submitters of #179 and #281 to fix the link errors on both freebsd and redhat 6.