Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup_requirements to match pyproject.toml #485

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

kubinski
Copy link
Contributor

Updated setup_requirements to match the requirements listed in pyproject.toml.

Updated setup_requirements to match the requirements listed in pyproject.toml.
@lmctv
Copy link
Contributor

lmctv commented Nov 3, 2018

@pyca/pynacl-core @dstufft I seem to remember using setup_requirements is deprecated when building with pip. If this is the case, I think we should add a comment before the empty list in setup.py

@reaperhulk
Copy link
Member

setup_requires are deprecated by pyproject.toml but we need to retain them until we decide to drop support for pips without pyproject.toml support (aka everything except the latest release right now)

Copy link
Contributor

@lmctv lmctv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is still useful. Will merge.

@lmctv lmctv merged commit 2fc1d52 into pyca:master Dec 24, 2018
@kitterma
Copy link
Contributor

The problem with this change is what wheel is only required if you are building a wheel. Not everyone does this, so it seems odd to require it. Particularly since wheel being available to pip is the default in a virtualenv. Since I'm not building a wheel, now I have to carry this pointless requirement or patch the project.

@reaperhulk
Copy link
Member

@kitterma Yeah I'd be happy to take a PR removing that. We don't do it in pyca/cryptography and there's no reason to do it here.

@kitterma
Copy link
Contributor

@reaperhulk OK. See #596. Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants