-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled version of libsodium sources to version 1.0.18 (#536) #541
Conversation
@dciabrin sorry, but it seems this time there is more stuff in the committed libsodium than in the upstream tarball:
Are you sure you downloaded and extracted the right tarball from https://download.libsodium.org/libsodium/releases/ ? |
@lmctv argh apologies I've downloaded https://github.com/jedisct1/libsodium/archive/1.0.18-RELEASE.tar.gz instead. Let me fix that at once... |
05a9f2a
to
fb87637
Compare
Also a quick note before I make you lose more time: libsodium-1.0.18 doesn't include config.guess and config.sub anymore on the root dir. They now include it under ./build-aux sub directory. Unfortunately due to jedisct1/libsodium@515d540, those two files are now bundled without +x permission. setup.py ensures they get +x, but as a side effect they now show as modified in git as soon as setup.py is ran. |
setup.py
Outdated
"src/libsodium/config.guess", | ||
"src/libsodium/config.sub", | ||
"src/libsodium/build-aux/config.guess", | ||
"src/libsodium/build-aux/config.sub", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By looking at how the commands involving config.guess
and config.sub
are invoked in ./configure:
`$SHELL "$ac_aux_dir/config.guess"`
`$SHELL "$ac_aux_dir/config.sub"`
it seems the execute permission is not needed anymore for the configure step to succeed.
I'd suggest to just remove these files from the list, and verify the library is still correctly built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking the bundled version is equal to the one extracted from a pristine upstream tar, I just verified the git worktree stays clean after building. Merging.
This version extends the ed25519 API, with scalar*scalar (mod L) multiplication, and new functions to map a hash to an edwards25519 point or get a random point. It also implements finite field arithmetic for the Ristretto group.
fb87637
to
01fa56f
Compare
This version extends the ed25519 API, with scalar*scalar (mod L)
multiplication, and new functions to map a hash to an edwards25519
point or get a random point. It also implements finite field
arithmetic for the Ristretto group.