Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python and PyPy version updates #130

Merged
merged 8 commits into from Jun 9, 2017
Merged

Python and PyPy version updates #130

merged 8 commits into from Jun 9, 2017

Conversation

ashfall
Copy link
Contributor

@ashfall ashfall commented Jun 9, 2017

  • Drop Python 3.3
  • Add Python 3.6
  • Bump PyPy version to 5.7.0 for travis

@ashfall
Python and PyPy version updates
a30b8e0 
- Drop Python 3.3
- Add Python 3.6
- Bump PyPy version to 5.7.0 for travis
@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling a30b8e0 on ashfall:drop-33-add-36 into 6106a21 on pyca:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling c45a683 on ashfall:drop-33-add-36 into 6106a21 on pyca:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 3b69231 on ashfall:drop-33-add-36 into 6106a21 on pyca:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling ff8be99 on ashfall:drop-33-add-36 into 6106a21 on pyca:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling c0520d1 on ashfall:drop-33-add-36 into 6106a21 on pyca:master.

markrwilliams
markrwilliams approved these changes Jun 9, 2017
View reviewed changes
Copy link
Member

@markrwilliams markrwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I put some comments on the changes for posterity -- please double check them when you get a chance.

.travis.yml
@@ -1,18 +1,18 @@
language: python
sudo: false
dist: trusty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows PyPy 5.7 to work.

.travis.yml
env: TOXENV=py3pep8

install:
- pip install coveralls tox
- |
if [ "${TOXENV}" == "pypy" ]
then
rm -rf ~/.pyenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that a problem with pyenv doesn't cause future builds to fail.

tox.ini
@@ -33,7 +32,7 @@ deps =
pytest
doc8
pyenchant
sphinx
sphinx<1.6.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sphinx 1.6.1 breaks the spell checker.

@markrwilliams markrwilliams merged commit 9927161 into python-tls:master Jun 9, 2017
@ashfall
Copy link
Contributor Author

ashfall commented Jun 9, 2017 •
edited

@markrwilliams Thanks a lot! The comments are right on point! Thanks for documenting this :)

@ashfall ashfall deleted the drop-33-add-36 branch June 9, 2017 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markrwilliams markrwilliams markrwilliams approved these changes

@reaperhulk reaperhulk Awaiting requested review from reaperhulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashfall @coveralls @markrwilliams