New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python and PyPy version updates #130
Conversation
ashfall
commented
Jun 9, 2017
- Drop Python 3.3
- Add Python 3.6
- Bump PyPy version to 5.7.0 for travis
- Drop Python 3.3 - Add Python 3.6 - Bump PyPy version to 5.7.0 for travis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I put some comments on the changes for posterity -- please double check them when you get a chance.
@@ -1,18 +1,18 @@ | |||
language: python | |||
sudo: false | |||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows PyPy 5.7 to work.
env: TOXENV=py3pep8 | ||
|
||
install: | ||
- pip install coveralls tox | ||
- | | ||
if [ "${TOXENV}" == "pypy" ] | ||
then | ||
rm -rf ~/.pyenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that a problem with pyenv doesn't cause future builds to fail.
@@ -33,7 +32,7 @@ deps = | |||
pytest | |||
doc8 | |||
pyenchant | |||
sphinx | |||
sphinx<1.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sphinx 1.6.1 breaks the spell checker.
@markrwilliams Thanks a lot! The comments are right on point! Thanks for documenting this :) |