-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add metastable composition sets to starting point #362
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #362 +/- ##
===========================================
+ Coverage 89.86% 89.91% +0.04%
===========================================
Files 44 44
Lines 4341 4362 +21
===========================================
+ Hits 3901 3922 +21
Misses 440 440
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a test and what does that look like? Do we need a unit test that checks that composition sets are added or is an integration test for a tricky case enough?
…`entered_phases` to clarify that `composition_sets` may already contain metastable entries
I think an integration test for a test case is the right idea, because the use of metastable composition sets in the starting point is an implementation detail. Do you have a good test case? I hesitate to use the multi-component system that inspired this because of the additional test time. |
…metastable augmentation of the starting point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together this PR!
…tion sets (#206) Incorporates the changes to the Dataset/LightDataset API introduced in pycalphad/pycalphad#362.
This PR adds a new function,
add_nearly_stable
, which augments the starting point of the solver with additionalCompositionSet
objects, which are entered with zero amount. These objects are added by the following criteria:The purpose of this change is to improve the accuracy of solutions when sampling densities are not high enough to find the true set of equilibrium composition sets. This can easily happen in the multi-component / multi-sublattice case.