ENH: Allow solution refinement by the Ipopt solver to be disabled. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it need a test? |
|
Maybe an integration test to validate that a certain point density gives a certain result? Do you have another suggestion? |
|
An integration test that exercises the code path and makes sure we return an answer without raising is fine. We don't make any accuracy promises with this mode. |
|
I have a sketch of a test written, but this has made me realize that the chemical potentials are all 0.0. The other properties seem correct. |
…tain fictitious points not on the hyperplane
|
Py3.5 tests pass due to some dependency luck, so this should just need a rebase on #192 to fix other platforms |
bocklund
added a commit
to bocklund/pycalphad
that referenced
this pull request
Aug 17, 2021
Fix a regression where `plot_interaction` and `plot_endmember` re-used reference labels and markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.