Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow solution refinement by the Ipopt solver to be disabled. #187

Merged
merged 10 commits into from Nov 14, 2018

Conversation

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Aug 28, 2018

No description provided.

@bocklund bocklund added this to the 0.7.1 milestone Aug 28, 2018
@richardotis
Copy link
Collaborator

@richardotis richardotis commented Sep 1, 2018

Does it need a test?

@bocklund
Copy link
Collaborator Author

@bocklund bocklund commented Sep 1, 2018

Maybe an integration test to validate that a certain point density gives a certain result? Do you have another suggestion?

@richardotis
Copy link
Collaborator

@richardotis richardotis commented Sep 1, 2018

An integration test that exercises the code path and makes sure we return an answer without raising is fine. We don't make any accuracy promises with this mode.

@bocklund
Copy link
Collaborator Author

@bocklund bocklund commented Nov 1, 2018

I have a sketch of a test written, but this has made me realize that the chemical potentials are all 0.0. The other properties seem correct.

@bocklund bocklund force-pushed the noopsolver branch from 9b2b45c to 7eb7bd0 Nov 1, 2018
@bocklund
Copy link
Collaborator Author

@bocklund bocklund commented Nov 1, 2018

Py3.5 tests pass due to some dependency luck, so this should just need a rebase on #192 to fix other platforms

@richardotis richardotis merged commit 0a570d4 into develop Nov 14, 2018
4 of 5 checks passed
4 of 5 checks passed
coverage/coveralls Coverage decreased (-0.4%) to 87.838%
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richardotis richardotis deleted the noopsolver branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants