Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding shape, color and size to plotting of benchmarks #52

Closed
ngupta23 opened this issue Feb 4, 2023 · 1 comment · Fixed by #53
Closed

Allow adding shape, color and size to plotting of benchmarks #52

ngupta23 opened this issue Feb 4, 2023 · 1 comment · Fixed by #53

Comments

@ngupta23
Copy link
Collaborator

ngupta23 commented Feb 4, 2023

Current

  • X axis = Time
  • Y axis = Primary Metric

Future

In addition to the current, add the following

  • Color = model
  • Shape = type (e.g. internal or external benchmark)
  • Size = secondary metric
ngupta23 added a commit that referenced this issue Feb 4, 2023
@ngupta23
Copy link
Collaborator Author

ngupta23 commented Feb 4, 2023

Plotly color map has more shapes than colors. Hence started with assigning shapes to models, but this is hard to visualize for humans, especially with so many models on the plot. Hence, decided to mix colors and shapes for models itself. This is much more pleasing for the eye.

Also, if secondary metrics need to be plotted, it can be done as a different plot.

@ngupta23 ngupta23 linked a pull request Feb 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant