Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first commit #1

Merged
merged 2 commits into from
Jun 13, 2020
Merged

first commit #1

merged 2 commits into from
Jun 13, 2020

Conversation

Agent-Hellboy
Copy link
Contributor

No description provided.

@Agent-Hellboy Agent-Hellboy reopened this Jun 10, 2020
@Agent-Hellboy
Copy link
Contributor Author

Agent-Hellboy commented Jun 10, 2020 •
edited
Loading

hi there,
When I was preparing for a GSOC proposal I came across this repo. I found there is no activity since 2019. I thought nowadays everyone is using sqlalchemy that's why there is no commit since 2019. But the sqlobject is not archived yet it is actively maintained by its author having a commit in March 2020. I have tried my best to follow the structure of the casbin_sqlalchemy_adapter. If you guys approve this then I will implement API for remove_policy and remove_filtered_policy. I will also prepare the setup file and upload it to PyPI also.

@hsluoyz
Copy link
Member

hsluoyz commented Jun 10, 2020

@techoner please review.

@leeqvip leeqvip self-requested a review June 13, 2020 10:07
leeqvip
leeqvip requested changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@leeqvip leeqvip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@princekrroshan01 Please format.

@leeqvip leeqvip merged commit bf936fa into pycasbin:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeqvip leeqvip leeqvip requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Agent-Hellboy @hsluoyz @leeqvip