Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate theme #16

Merged
merged 6 commits into from Feb 19, 2019
Merged

Conversation

abeyer
Copy link
Contributor

@abeyer abeyer commented Feb 10, 2019

A potential option for #3

I'm not strongly in favor of any particular theme, but alabaster is a bit buggy on mobile, so anything else would likely be an improvement. I played with a couple and this seems nice and simple.

@abeyer abeyer changed the title Abeyer/theme playground alternate theme Feb 10, 2019
@abeyer
Copy link
Contributor Author

abeyer commented Feb 10, 2019

ugh, I love travis 🙄

One thing to note is that this doesn't support the github banner widget...probably not a big deal since we have a whole paragraph about contributing at the top of the page.

@Mariatta Mariatta closed this Feb 13, 2019
@Mariatta Mariatta reopened this Feb 13, 2019
@Mariatta
Copy link
Member

Looks great!! Preview is here: https://deploy-preview-16--relaxed-lalande-396fdc.netlify.com/

@Mariatta
Copy link
Member

Thanks @abeyer, the new theme looks really great!
We have a new logo (as of few days ago), will you be able to update with the new logo? It can be seen in our main website.
Once we have new logo I can merge this.
Thanks!

@Mariatta Mariatta mentioned this pull request Feb 13, 2019
@Mariatta
Copy link
Member

Something that just occurred to me is, while the new theme looks great, I'm a little uncomfortable that it doesn't support readthedocs' ethical advertising (available in alabaster, rtd's sphinx theme, and mkdocs). My personal recommendation is not switching to another theme unless we (pycascades) can support readthedocs some other way.

@ndenny
Copy link
Collaborator

ndenny commented Feb 18, 2019

After @abeyer 's kind donation, I guess this is good to go?

@Mariatta
Copy link
Member

Yup. We need a new logo but I can do it in the next PR.
Thanks so much @abeyer!

@Mariatta Mariatta merged commit 4298bd2 into pycascades:master Feb 19, 2019
@Mariatta Mariatta mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants