Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate theme #16

Merged
merged 6 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@abeyer
Copy link
Contributor

abeyer commented Feb 10, 2019

A potential option for #3

I'm not strongly in favor of any particular theme, but alabaster is a bit buggy on mobile, so anything else would likely be an improvement. I played with a couple and this seems nice and simple.

abeyer added some commits Feb 10, 2019

@abeyer abeyer changed the title Abeyer/theme playground alternate theme Feb 10, 2019

abeyer added some commits Feb 10, 2019

@abeyer

This comment has been minimized.

Copy link
Contributor Author

abeyer commented Feb 10, 2019

ugh, I love travis 🙄

One thing to note is that this doesn't support the github banner widget...probably not a big deal since we have a whole paragraph about contributing at the top of the page.

@Mariatta Mariatta closed this Feb 13, 2019

@Mariatta Mariatta reopened this Feb 13, 2019

@Mariatta

This comment has been minimized.

Copy link
Member

Mariatta commented Feb 13, 2019

@Mariatta

This comment has been minimized.

Copy link
Member

Mariatta commented Feb 13, 2019

Thanks @abeyer, the new theme looks really great!
We have a new logo (as of few days ago), will you be able to update with the new logo? It can be seen in our main website.
Once we have new logo I can merge this.
Thanks!

@Mariatta Mariatta referenced this pull request Feb 13, 2019

Merged

Create requirements.txt #20

@Mariatta

This comment has been minimized.

Copy link
Member

Mariatta commented Feb 14, 2019

Something that just occurred to me is, while the new theme looks great, I'm a little uncomfortable that it doesn't support readthedocs' ethical advertising (available in alabaster, rtd's sphinx theme, and mkdocs). My personal recommendation is not switching to another theme unless we (pycascades) can support readthedocs some other way.

@ndenny

This comment has been minimized.

Copy link
Collaborator

ndenny commented Feb 18, 2019

After @abeyer 's kind donation, I guess this is good to go?

@Mariatta

This comment has been minimized.

Copy link
Member

Mariatta commented Feb 19, 2019

Yup. We need a new logo but I can do it in the next PR.
Thanks so much @abeyer!

@Mariatta Mariatta merged commit 4298bd2 into pycascades:master Feb 19, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details

@Mariatta Mariatta referenced this pull request Feb 20, 2019

Closed

Improve theme? #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.