Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to DiscreteDerham #349

Merged
merged 92 commits into from
Dec 1, 2023
Merged

Add documentation to DiscreteDerham #349

merged 92 commits into from
Dec 1, 2023

Conversation

vcarlier
Copy link
Contributor

This PR just adds some documentation to the methods and properties of DiscreteDerham.
This was discussed on PR #282 but then was merged before the whole documentation was added

vcarlier and others added 30 commits March 10, 2023 15:37
added uptating ghost regions before assembling a form and a test show…
6e1000f 
…ing where the error could show up
correction for the call of backups in the test
99364d7
added the Hvec projection, and the space on the derham sequence with …
9d9e3d7 
…the keyword get_vec
added the basis projector operators, started to implement some tests
bb783cb
added tests for the basis projectors, there seems to be a problem in …
379c5b7 
…periodic case
basis operators now available, all test passing
296ac74
resolving the conflicts
ac91c73
@vcarlier
Merge branch 'devel' into add_Hvec
0ab2737
forgotten add file
ec67c87
Merge branch 'add_Hvec' of https://github.com/pyccel/psydac into add_…
b358b3a 
…Hvec
fix for the transpose, added the fix in block linop
064a578
fix in linalg.block, add tests and a fix (probably temporary) when pa…
20a64d9 
…ssing a FemField to basis projector
Fix to able the basis projection operators to be used with femfields …
867fc96 
…as parameter
remove ome useless args in dot function of basis projection operator
31b9cb8
solving problem with points that could go outside of the domains in p…
c0d8b8d 
…eriodic cases, rectangular tests for the basis projection operators
few changes in basis_projectors
3d1478e
merge devel in branch
fda85b7
few fixes after the merge of devel
6db4a90
changes on pull_back for the v_space to match other changes and added…
37fd71b 
… test for the basis projection operator on mapped domains
Merge branch 'devel' into add_Hvec
88516fa
fix useless stuff for codacity
04c5b82
add the possibility to have a metric to compute the error on the Bico…
4e45d5b 
…njugate gradient (stabilized) solvers
add nb cells in basis projectors to use eval field regular tensor grid
6cf8855
little rectification in basis proj operator
a59ac87
@vcarlier
Delete .lock_acquisition.lock
ecdaab5
@vcarlier
Update test_assembly.py
43c0033 
delete useless space
optimization : can now set a Basis projection operator with given mat…
d099ad1 
…rix so that you don't have to compute it, particularly usefull when transposing and one can now pass the space data in order to avoid multiple computation of the same data
optimzed te creation of he basis projection operator in case the coef…
50d223e 
…ficient are Femfields
add kernels in 1d and 3d, updated kernel docstrings for the femfield …
8146777 
…case
Merge branch 'add_metric_solver' into add_Hvec
495a888
vcarlier added 15 commits October 10, 2023 16:41
@vcarlier vcarlier requested a review from a team October 25, 2023 08:05
campospinto
campospinto requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Valentin this is useful ! I added a few comments and suggestions

psydac/api/feec.py Outdated Show resolved Hide resolved
psydac/api/feec.py Outdated Show resolved Hide resolved
psydac/api/feec.py Outdated Show resolved Hide resolved
psydac/api/feec.py Outdated Show resolved Hide resolved
psydac/api/feec.py Outdated Show resolved Hide resolved
psydac/api/feec.py Outdated Show resolved Hide resolved
campospinto
campospinto reviewed Nov 29, 2023
View reviewed changes
psydac/api/feec.py Outdated Show resolved Hide resolved
campospinto
campospinto approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@campospinto
Copy link
Contributor

Thanks Yaman for these commits 👍

@yguclu
Copy link
Member

yguclu commented Dec 1, 2023

Thanks Yaman for these commits 👍

If only I had not introduced a bug! 😅

@yguclu yguclu merged commit 5eefba6 into devel Dec 1, 2023
6 checks passed
@yguclu yguclu deleted the add_Hvec branch December 1, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu left review comments

@campospinto campospinto campospinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcarlier @campospinto @yguclu @jowezarek