Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid Suffix on Literal with PRId in C++11 #63

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

smazouz42
Copy link

This pull request addresses issue #62 by adding a space between the % and PRId64/PRId16/PRId8 to fix that.

@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@github-actions github-actions bot marked this pull request as draft June 28, 2024 16:14
@smazouz42 smazouz42 changed the title fix: add space between '%' and PRId64 to resolve C++11 compilation wa… Fix Invalid Suffix on Literal with PRId64 in C++11 Jun 28, 2024
@smazouz42 smazouz42 marked this pull request as ready for review June 28, 2024 16:16
@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

@github-actions github-actions bot marked this pull request as draft June 28, 2024 16:16
@smazouz42 smazouz42 marked this pull request as ready for review June 28, 2024 16:17
@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

@smazouz42
Copy link
Author

smazouz42 commented Jun 28, 2024

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@github-actions github-actions bot marked this pull request as draft June 28, 2024 16:17
@smazouz42
Copy link
Author

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@smazouz42 smazouz42 changed the title Fix Invalid Suffix on Literal with PRId64 in C++11 Fix Invalid Suffix on Literal with PRId in C++11 Jun 28, 2024
@smazouz42 smazouz42 marked this pull request as ready for review June 28, 2024 17:14
@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft June 28, 2024 17:14
@smazouz42 smazouz42 marked this pull request as ready for review June 28, 2024 17:16
@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft June 28, 2024 17:17
@smazouz42 smazouz42 marked this pull request as ready for review June 28, 2024 17:17
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@github-actions github-actions bot marked this pull request as draft June 28, 2024 17:18
@pyccel-bot
Copy link

pyccel-bot bot commented Jun 28, 2024

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@smazouz42 smazouz42 marked this pull request as ready for review July 2, 2024 14:44
@pyccel-bot
Copy link

pyccel-bot bot commented Jul 2, 2024

There are unrecognised tests.
The following is a list of keywords which can be used to run tests. Tests in bold are run by pull requests when they are marked as ready for review:

  • linux : Runs the unit tests on a Linux system.
  • windows : Runs the unit tests on a Windows system.
  • macosx : Runs the unit tests on a MacOS X system.
  • cuda : Runs the cuda unit tests on a Linux system.
  • coverage : Runs the unit tests on a Linux system and checks the coverage of the tests.
  • docs : Checks if the documentation follows the numpydoc format.
  • pylint : Runs pylint on files which are too big to be handled by codacy.
  • pyccel_lint : Runs a linter to check that Pyccel's best practices are followed.
  • spelling : Checks if everything in the documentation is spelled (and capitalised) correctly.
  • pr_tests : Runs all the tests marked in bold.
  • pickle : Checks that .pyccel files have been correctly generated and installed by the installation process.
  • editable_pickle : Checks that .pyccel files have been correctly generated and installed by the editable installation process.
  • pickle_wheel : Checks that .pyccel files have been correctly generated and packaged into the wheel.
  • anaconda_linux : Runs the unit tests on a linux system using anaconda for python.
  • anaconda_windows : Runs the unit tests on a windows system using anaconda for python.
  • intel : Runs the unit tests on a linux system using the intel compiler.

These tests can be run with the command /bot run X (multiple tests can be specified separated by spaces), or with try V X to test on Python version V.

@smazouz42
Copy link
Author

/bot run linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant