-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Invalid Suffix on Literal with PRId in C++11 #63
base: devel
Are you sure you want to change the base?
Conversation
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using |
I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using |
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with |
It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
There are unrecognised tests.
These tests can be run with the command |
/bot run linux |
This pull request addresses issue #62 by adding a space between the % and PRId64/PRId16/PRId8 to fix that.