Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gFTL is installed with Pyccel #1656

Closed
EmilyBourne opened this issue Jan 10, 2024 · 0 comments · Fixed by #1809
Closed

Ensure gFTL is installed with Pyccel #1656

EmilyBourne opened this issue Jan 10, 2024 · 0 comments · Fixed by #1809
Assignees
Labels
Containers tuples/lists/sets/maps enhancement internals Pyccel's internal behavior, does not affect user experience

Comments

@EmilyBourne
Copy link
Member

Relevant Discussion

#1053 (comment)

Describe the feature

In order to add support for containers we need to include our new dependencies in Pyccel and ensure that they are correctly installed. In C we will use https://github.com/Goddard-Fortran-Ecosystem/gFTL . We need to make sure that the necessary files for compilation are packaged with Pyccel.

Proposed Solution

Add https://github.com/Goddard-Fortran-Ecosystem/gFTL as a git submodule. Update the pyproject.toml file to ensure that the necessary files from STC are installed with Pyccel. We do not need to install the docs from the library.

There may need to be an investigation to find the most appropriate way to handle this. I think it would be a good idea to create a folder called extensions at the root and keep dependencies here. It is not clear how to map the include and src folders to the Pyccel folder from there. The solution will involve artifacts and may require symbolic links

@EmilyBourne EmilyBourne added enhancement internals Pyccel's internal behavior, does not affect user experience Containers tuples/lists/sets/maps labels Jan 10, 2024
@mustapha-belbiad mustapha-belbiad self-assigned this Mar 27, 2024
EmilyBourne pushed a commit that referenced this issue Apr 17, 2024
- Add `https://github.com/Goddard-Fortran-Ecosystem/gFTL` as a git
submodule.
- Update the `pyproject.toml` file to include essential files from gFTL.
- Implement a GitHub Action in `check_for_gftl` to verify gFTL
installation.

This fixes #1656.

---------

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Containers tuples/lists/sets/maps enhancement internals Pyccel's internal behavior, does not affect user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants