Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce use of types decorator #1470

Merged
merged 90 commits into from
Aug 15, 2023
Merged

Reduce use of types decorator #1470

merged 90 commits into from
Aug 15, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Jul 31, 2023 •
edited
Loading

Use the script tools/remove_types.py to remove unnecessary @types decorators in tests/. Fix a few additional corner cases manually. Tidy up documentation

@EmilyBourne
Copy link
Member Author

/bot run linux

@pyccel-bot
Copy link

pyccel-bot bot commented Jul 31, 2023 •
edited by EmilyBourne
Loading

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne
Copy link
Member Author

/bot run linux

@EmilyBourne
Copy link
Member Author

/bot run linux

Base automatically changed from devel-issue1258 to devel August 15, 2023 08:32
@EmilyBourne EmilyBourne removed the blocked Cannot be solved/merged until something else is fixed label Aug 15, 2023
@yguclu
Copy link
Member

yguclu commented Aug 15, 2023

/bot run pr_tests

@github-actions github-actions bot marked this pull request as draft August 15, 2023 08:47
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label Aug 15, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 15, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@EmilyBourne EmilyBourne marked this pull request as ready for review August 15, 2023 09:01
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 15, 2023

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft August 15, 2023 09:02
@EmilyBourne EmilyBourne marked this pull request as ready for review August 15, 2023 09:14
pyccel-bot[bot]
pyccel-bot bot approved these changes Aug 15, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

yguclu
yguclu reviewed Aug 15, 2023
View reviewed changes
docs/templates.md Outdated Show resolved Hide resolved
yguclu
yguclu reviewed Aug 15, 2023
View reviewed changes
docs/templates.md Outdated Show resolved Hide resolved
yguclu
yguclu reviewed Aug 15, 2023
View reviewed changes
docs/templates.md Outdated Show resolved Hide resolved
@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label Aug 15, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 15, 2023

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @EniddeallA think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@EmilyBourne
Copy link
Member Author

/bot run pr_tests

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Aug 15, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 15, 2023

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @EniddeallA think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

yguclu
yguclu approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Everything looks good to me.

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Aug 15, 2023
@yguclu yguclu merged commit 4943108 into devel Aug 15, 2023
13 checks passed
@yguclu yguclu deleted the ebourne_reduce_types_decorator branch August 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

@EniddeallA EniddeallA EniddeallA approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmilyBourne @yguclu @EniddeallA