Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C support for a class containing only scalar data #1472

Merged
merged 94 commits into from
Sep 6, 2023
Merged

Add C support for a class containing only scalar data #1472

merged 94 commits into from
Sep 6, 2023

Conversation

sboof911
Copy link
Member

@sboof911 sboof911 commented Aug 1, 2023 •
edited
Loading

Add visiting the lhs of a DottedVariable.
Add is_argument = True for the self variable when it's in a method argument of a class.
Add the declaration of the attributes of the class in the struct def.

sboof911 and others added 30 commits July 21, 2023 09:51
@sboof911
Printing Header c
b9db1a5
@sboof911
Adding the printing of the function of the class
9b019a8
@sboof911
Add ConstructorCall
7d649d7
@sboof911
CHANGELOG
055f90a
@sboof911
Adding Tests
e7322cf
@sboof911
from an Assign(Variable, ConstructorCall) to a ConstructorCall
36d6777
@sboof911
Update semantic.py
3c75d18
@sboof911
merge devel
463a710
@sboof911
merge devel
ba341d5
@sboof911
from an Assign(Variable, ConstructorCall) to a ConstructorCall
bf72c1c
@sboof911
Update semantic.py
4c2f8e3
@sboof911
ConstructorCall inherit from DottedFunctionCall
8aa9377
@sboof911
fix inheritance
9997703
@sboof911
fixing inheritance
f97c87e
@sboof911
Assign to ConstructorCall
963ebd9
@sboof911
deleting unnecessary code
224178a
@sboof911
deleting unnecessary code
8d1f84a
@sboof911
deleting unnecessary code
a3dc71f
@sboof911
deleting unnecessary code
585bc3b
@sboof911
optimizing the ConstructorCall
0b087b6
@sboof911
deleting unnecessary code from _infer_type
62a45ab
@sboof911
some minor change
90a776f
@sboof911
some minor change
3c20f6e
@sboof911
cleaning code
ef25891
@sboof911 @EmilyBourne
Update semantic
ec3274e 
Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
@sboof911
fixing errors in pycode.py
920bba1
@sboof911
fixing errors in pycode.py
6262381
@sboof911
fix fortran ContructorCall
ed42d9d
@sboof911
fix fortran ContructorCall
e0c5e6c
@sboof911
merge
121b961
@sboof911
Copy link
Member Author

sboof911 commented Sep 4, 2023

/bot run docs pylint pyccel_lint spelling

@sboof911
Copy link
Member Author

sboof911 commented Sep 4, 2023

/bot mark as ready

@github-actions github-actions bot marked this pull request as ready for review September 4, 2023 14:51
pyccel-bot[bot]
pyccel-bot bot approved these changes Sep 4, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label Sep 4, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Sep 4, 2023

@EmilyBourne, @sboof911 has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?

EmilyBourne
EmilyBourne requested changes Sep 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft September 4, 2023 19:14
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label Sep 4, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Sep 4, 2023

@sboof911, @EmilyBourne has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with /bot mark as ready and we will see if we can get approval.

@EmilyBourne
Copy link
Member

This seems really clean. I just have a grammar comment then I'm happy

@sboof911 @EmilyBourne
Update CHANGELOG.md
39ddc93 
Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
@sboof911
Copy link
Member Author

sboof911 commented Sep 4, 2023

/bot mark as ready

@github-actions github-actions bot marked this pull request as ready for review September 4, 2023 19:18
@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label Sep 4, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Sep 4, 2023

@EmilyBourne, @sboof911 has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Sep 4, 2023
@sboof911 sboof911 added the urgent Affects all PRs and should be merged as soon as possible label Sep 5, 2023
@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_to_merge Approved by senior developer. Ready for final approval and merge labels Sep 6, 2023
@yguclu
Copy link
Member

yguclu commented Sep 6, 2023

@sboof911 Is the PR description up to date? I do not see a clear correspondence with the changes made.

@sboof911
Copy link
Member Author

sboof911 commented Sep 6, 2023

@sboof911 Is the PR description up to date? I do not see a clear correspondence with the changes made.

Fixed.

@yguclu yguclu merged commit c6d7613 into devel Sep 6, 2023
11 checks passed
@yguclu yguclu deleted the issue#1439 branch September 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

@mkaddani mkaddani mkaddani approved these changes

@EmilyBourne EmilyBourne EmilyBourne approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
Classes Ready_to_merge Approved by senior developer. Ready for final approval and merge urgent Affects all PRs and should be merged as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C support for a class containing only scalar data
4 participants
@sboof911 @yguclu @EmilyBourne @mkaddani