Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOT] Fix docs for ci_tools #1483

Merged
merged 18 commits into from
Aug 13, 2023
Merged

[BOT] Fix docs for ci_tools #1483

merged 18 commits into from
Aug 13, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Aug 8, 2023 •
edited

Coverage should not raise an issue if an except statement is not covered (we do not enforce coverage for error statements such as raise and errors.report, this is similar and the body of the except clause will still raise an issue if anything more complex is used). This PR adds except to the exceptions.

Correcting this leads to an error with the documentation. The error arises because numpydoc imports all files that it tests so all possible dependencies must be installed. This is corrected in this PR. This issue has previously been misunderstood and fixed by trying to import from different locations. The unnecessary code is therefore removed.

The tests were triggering manually on this branch to ensure it can pass and to test the fix.

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 8, 2023 •
edited by EmilyBourne

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne EmilyBourne linked an issue Aug 8, 2023 that may be closed by this pull request
[BOT] Documentation problems when changing files in ci_tools #1482
Closed
@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne EmilyBourne added the Bot label Aug 8, 2023
@EmilyBourne EmilyBourne marked this pull request as ready for review August 8, 2023 11:30
pyccel-bot[bot]
pyccel-bot bot approved these changes Aug 8, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 8, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

sboof911
sboof911 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@sboof911 sboof911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed needs_initial_review labels Aug 8, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 8, 2023

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @sboof911 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@EmilyBourne EmilyBourne mentioned this pull request Aug 9, 2023
Merged
@EmilyBourne
Copy link
Member Author

/bot run pr_tests

@github-actions github-actions bot marked this pull request as draft August 10, 2023 06:47
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label Aug 10, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 10, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@pyccel pyccel deleted a comment from pyccel-bot bot Aug 10, 2023
@yguclu
Update list_docs_tovalidate.py
7d55427 
Minor changes to comment block.
@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot run pr_tests

@github-actions github-actions bot marked this pull request as draft August 13, 2023 15:59
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label Aug 13, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@yguclu yguclu marked this pull request as ready for review August 13, 2023 16:05
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @sboof911 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Aug 13, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @sboof911 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Aug 13, 2023
@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot run pr_tests

@github-actions github-actions bot marked this pull request as draft August 13, 2023 16:14
@pyccel-bot pyccel-bot bot removed the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Aug 13, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@yguclu yguclu marked this pull request as ready for review August 13, 2023 16:16
pyccel-bot[bot]
pyccel-bot bot approved these changes Aug 13, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Aug 13, 2023
@yguclu yguclu merged commit 0c91c72 into devel Aug 13, 2023
11 of 12 checks passed
@yguclu yguclu deleted the devel-issue1482 branch August 13, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

@sboof911 sboof911 sboof911 approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
Bot Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BOT] Documentation problems when changing files in ci_tools
3 participants
@EmilyBourne @yguclu @sboof911