Add support for cmath #1511
Add support for cmath #1511
Conversation
|
/bot run coverage docs pylint pyccel_lint |
|
Hello again! Thank you for this new pull request 🤩. Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
|
/bot run docs pylint |
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
There was a problem hiding this comment.
There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.
If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.
Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.
| super().__init__(z) | ||
|
|
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
There was a problem hiding this comment.
/bot accept
Code is only provided to ensure the docstrings are aware of the parameter names
| super().__init__(r, phi) | ||
|
|
||
| #============================================================================== | ||
| # Dictionary to map cmath functions to classes above | ||
| #============================================================================== | ||
|
|
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
There was a problem hiding this comment.
/bot accept
Code is only provided to ensure the docstrings are aware of the parameter names
|
/bot run coverage |
|
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
|
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
|
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
|
/bot run docs |
|
/bot run pr_tests |
pyccel-bot
bot
added
Ready_to_merge
pyccel-bot
bot
removed
the
Ready_to_merge
pyccel-bot
bot
added
the
Ready_to_merge
Add support for the cmath library using similar methods to those used for the math library. Fixes #1422