Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devel branch tests #1543

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Fix devel branch tests #1543

merged 3 commits into from
Oct 12, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Oct 12, 2023

Version strings shouldn't be quoted. The shell should always be specified for actions in a workflow to ensure the syntax is valid.
Modify bot_clean_up.py to exit if the associated pull request has been closed (e.g. because it has been merged).

@pyccel-bot
Copy link

pyccel-bot bot commented Oct 12, 2023

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review October 12, 2023 12:46
@github-actions github-actions bot marked this pull request as draft October 12, 2023 12:55
@EmilyBourne EmilyBourne marked this pull request as ready for review October 12, 2023 13:01
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@github-actions github-actions bot marked this pull request as draft October 12, 2023 13:12
@pyccel-bot
Copy link

pyccel-bot bot commented Oct 12, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@EmilyBourne EmilyBourne marked this pull request as ready for review October 12, 2023 13:52
@pyccel-bot
Copy link

pyccel-bot bot commented Oct 12, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team October 12, 2023 13:52
@EmilyBourne
Copy link
Member Author

Tests failing on Windows with anaconda due to textx. I have opened an issue here: textX/textX#411

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Oct 12, 2023
@yguclu yguclu merged commit da607a5 into devel Oct 12, 2023
20 of 22 checks passed
@yguclu yguclu deleted the ebourne_bug_fix branch October 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants