-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix devel branch tests #1543
Fix devel branch tests #1543
Conversation
Hello again! Thank you for this new pull request 🤩. Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
Tests failing on Windows with anaconda due to textx. I have opened an issue here: textX/textX#411 |
Version strings shouldn't be quoted. The shell should always be specified for actions in a workflow to ensure the syntax is valid.
Modify
bot_clean_up.py
to exit if the associated pull request has been closed (e.g. because it has been merged).