-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel tests to devel branch #1547
Conversation
Hello again! Thank you for this new pull request 🤩. Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
Intel installation tested here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using |
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
Add the configuration files to run tests with an Intel compiler. To this end add an environment variable
PYCCEL_DEFAULT_COMPILER
which specifies the default compiler.There are 3 failing tests due to:
Additionally some array tests were modified to use
isclose
for comparisons instead ofnp.all_equal
these tests all involve divisions and should have been usingisclose
anyway.This is related to #542 but does not fully fix the issue as it only adds Intel.