Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intel tests to devel branch #1547

Merged
merged 15 commits into from
Oct 13, 2023
Merged

Add Intel tests to devel branch #1547

merged 15 commits into from
Oct 13, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Oct 13, 2023

Add the configuration files to run tests with an Intel compiler. To this end add an environment variable PYCCEL_DEFAULT_COMPILER which specifies the default compiler.

There are 3 failing tests due to:

Additionally some array tests were modified to use isclose for comparisons instead of np.all_equal these tests all involve divisions and should have been using isclose anyway.

This is related to #542 but does not fully fix the issue as it only adds Intel.

@pyccel-bot
Copy link

pyccel-bot bot commented Oct 13, 2023

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review October 13, 2023 08:12
@EmilyBourne
Copy link
Member Author

Intel installation tested here:
https://github.com/EmilyBourne/pyccel/actions/workflows/intel.yml

@EmilyBourne EmilyBourne marked this pull request as draft October 13, 2023 08:14
@EmilyBourne EmilyBourne marked this pull request as ready for review October 13, 2023 08:19
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Oct 13, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team October 13, 2023 08:44
@yguclu yguclu changed the title Add intel tests to devel branch Add Intel tests to devel branch Oct 13, 2023
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Oct 13, 2023
@yguclu
Copy link
Member

yguclu commented Oct 13, 2023

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@github-actions github-actions bot marked this pull request as draft October 13, 2023 11:15
@pyccel-bot
Copy link

pyccel-bot bot commented Oct 13, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@pyccel-bot pyccel-bot bot removed the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Oct 13, 2023
@EmilyBourne EmilyBourne marked this pull request as ready for review October 13, 2023 11:47
@pyccel-bot
Copy link

pyccel-bot bot commented Oct 13, 2023

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

@EmilyBourne
Copy link
Member Author

EmilyBourne commented Oct 13, 2023

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as draft October 13, 2023 12:03
@EmilyBourne EmilyBourne marked this pull request as ready for review October 13, 2023 12:03
@pyccel-bot pyccel-bot bot added the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Oct 13, 2023
@yguclu yguclu merged commit 17c6819 into devel Oct 13, 2023
13 checks passed
@yguclu yguclu deleted the devel-issue542 branch October 13, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants