-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply some Pylint fixes : Part 1 #1591
Conversation
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
/bot run docs |
/bot run docs |
/bot run docs |
/bot run docs |
/bot run docs |
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Apply Pylint fixes and add docs to
pyccel.ast.bitwise_operators
andpyccel.ast.class_defs
. Modify the pylint workflow to run on as many files in the pyccel/ast/ directory as is currently possible. This list will be expanded over several PRs until all ast files can be checked directly.Also fix minor bot bug where the coverage checks the wrong line