Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some Pylint fixes : Part 1 #1591

Merged
merged 15 commits into from
Nov 3, 2023
Merged

Apply some Pylint fixes : Part 1 #1591

merged 15 commits into from
Nov 3, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Oct 30, 2023

Apply Pylint fixes and add docs to pyccel.ast.bitwise_operators and pyccel.ast.class_defs. Modify the pylint workflow to run on as many files in the pyccel/ast/ directory as is currently possible. This list will be expanded over several PRs until all ast files can be checked directly.

Also fix minor bot bug where the coverage checks the wrong line

@pyccel-bot
Copy link

pyccel-bot bot commented Oct 30, 2023

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne
Copy link
Member Author

EmilyBourne commented Oct 30, 2023

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review October 30, 2023 12:28
@github-actions github-actions bot marked this pull request as draft October 30, 2023 12:32
@pyccel-bot
Copy link

pyccel-bot bot commented Oct 30, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne
Copy link
Member Author

/bot run docs

@EmilyBourne EmilyBourne marked this pull request as ready for review October 30, 2023 14:09
@EmilyBourne
Copy link
Member Author

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Oct 30, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team October 30, 2023 14:46
pyccel/ast/operators.py Outdated Show resolved Hide resolved
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Nov 3, 2023
@yguclu yguclu changed the title Apply some Pylint fixes Part 1 Apply some Pylint fixes : Part 1 Nov 3, 2023
@EmilyBourne
Copy link
Member Author

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_to_merge Approved by senior developer. Ready for final approval and merge labels Nov 3, 2023
@yguclu yguclu merged commit b8075f0 into devel Nov 3, 2023
10 checks passed
@yguclu yguclu deleted the bitwise_docstrings branch November 3, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants