Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type annotation optional for self argument of bound methods #1626

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Make type annotation optional for self argument of bound methods #1626

merged 8 commits into from
Nov 22, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Nov 18, 2023 •
edited by yguclu

Make type annotation optional for the first argument (usually named self) of bound methods to conform to PEP 484. Fixes #1578.

This is done by adding the missing type annotation in the syntactic stage if there is no annotation present.

@pyccel-bot
Copy link

pyccel-bot bot commented Nov 18, 2023

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne
Copy link
Member Author

EmilyBourne commented Nov 18, 2023 •
edited

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne
Copy link
Member Author

/bot run linux pyccel_lint pylint

@EmilyBourne EmilyBourne marked this pull request as ready for review November 18, 2023 12:04
@pyccel-bot
Copy link

pyccel-bot bot commented Nov 18, 2023

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft November 18, 2023 12:04
@EmilyBourne
Copy link
Member Author

/bot run linux

@EmilyBourne EmilyBourne marked this pull request as ready for review November 18, 2023 13:08
@pyccel-bot
Copy link

pyccel-bot bot commented Nov 18, 2023

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft November 18, 2023 13:08
@EmilyBourne EmilyBourne marked this pull request as ready for review November 18, 2023 13:09
pyccel-bot[bot]
pyccel-bot bot approved these changes Nov 18, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Nov 18, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team November 18, 2023 13:25
@yguclu
Copy link
Member

yguclu commented Nov 22, 2023

/bot run pr_tests

pyccel-bot[bot]
pyccel-bot bot approved these changes Nov 22, 2023
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Nov 22, 2023
@yguclu yguclu changed the title Make type annotation optional for self argument of class methods Make type annotation optional for self argument of bound methods Nov 22, 2023
@yguclu yguclu changed the title Make type annotation optional for self argument of bound methods Make type annotation optional for self argument of bound methods Nov 22, 2023
@yguclu yguclu merged commit d01083b into devel Nov 22, 2023
10 checks passed
@yguclu yguclu deleted the devel-issue1578 branch November 22, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
Classes Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make type annotation optional for self argument of class methods
2 participants
@EmilyBourne @yguclu