Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #1761

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Remove dead code #1761

merged 4 commits into from
Feb 27, 2024

Conversation

EmilyBourne
Copy link
Member

The len function is handled through the __new__ function for all examples except homogeneous tuple literals. This does not need to be a special case. The unnecessary code is removed and tests are added.

@pyccel-bot
Copy link

pyccel-bot bot commented Feb 23, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne
Copy link
Member Author

EmilyBourne commented Feb 23, 2024 •
edited
Loading

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review February 23, 2024 17:07
@EmilyBourne EmilyBourne mentioned this pull request Feb 23, 2024
Merged
@github-actions github-actions bot marked this pull request as draft February 23, 2024 17:09
@pyccel-bot
Copy link

pyccel-bot bot commented Feb 23, 2024

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@EmilyBourne EmilyBourne marked this pull request as ready for review February 23, 2024 17:13
@EmilyBourne EmilyBourne added the internals Pyccel's internal behavior, does not affect user experience label Feb 23, 2024
@github-actions github-actions bot marked this pull request as draft February 23, 2024 17:15
pyccel-bot[bot]
pyccel-bot bot approved these changes Feb 23, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@EmilyBourne EmilyBourne marked this pull request as ready for review February 23, 2024 18:27
pyccel-bot[bot]
pyccel-bot bot approved these changes Feb 23, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Feb 23, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team February 23, 2024 18:29
Farouk-Echaref
Farouk-Echaref approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Farouk-Echaref Farouk-Echaref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed needs_initial_review labels Feb 26, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented Feb 26, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @Farouk-Echaref think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@EmilyBourne
Copy link
Member Author

/bot run pr_tests

@github-actions github-actions bot marked this pull request as draft February 26, 2024 10:20
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label Feb 26, 2024
pyccel-bot[bot]
pyccel-bot bot approved these changes Feb 26, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@EmilyBourne EmilyBourne marked this pull request as ready for review February 26, 2024 11:05
pyccel-bot[bot]
pyccel-bot bot approved these changes Feb 26, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label Feb 26, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented Feb 26, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @Farouk-Echaref think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Feb 27, 2024
@yguclu yguclu merged commit 46d0f51 into devel Feb 27, 2024
14 checks passed
@yguclu yguclu deleted the ebourne_len_cleaning branch February 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu yguclu approved these changes

@Farouk-Echaref Farouk-Echaref Farouk-Echaref approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
internals Pyccel's internal behavior, does not affect user experience Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmilyBourne @yguclu @Farouk-Echaref