Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some Pylint fixes, Part 1: Clean up parser #1826

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Conversation

EmilyBourne
Copy link
Member

The first of a few PRs which merge the changes from #1448 . This PR cleans up the parser/ folder by fixing missing fstrings . As a result docstrings are also improved.

@EmilyBourne
Copy link
Member Author

EmilyBourne commented Apr 9, 2024

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@pyccel-bot
Copy link

pyccel-bot bot commented Apr 9, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne EmilyBourne marked this pull request as ready for review April 9, 2024 21:24
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Apr 9, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team April 9, 2024 21:50
pyccel/parser/scope.py Outdated Show resolved Hide resolved
pyccel/parser/scope.py Outdated Show resolved Hide resolved
pyccel/parser/base.py Outdated Show resolved Hide resolved
pyccel/parser/base.py Outdated Show resolved Hide resolved
pyccel/parser/scope.py Outdated Show resolved Hide resolved
pyccel/parser/scope.py Outdated Show resolved Hide resolved
@EmilyBourne
Copy link
Member Author

/bot run pr_tests

@EmilyBourne
Copy link
Member Author

/bot run coverage

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Apr 11, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team April 11, 2024 07:06
@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Apr 11, 2024
@yguclu yguclu merged commit dcfdc6e into devel Apr 11, 2024
13 checks passed
@yguclu yguclu deleted the ebourne_codacy_part_1 branch April 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants