Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrapper Documentation. #1870

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix Wrapper Documentation. #1870

merged 1 commit into from
May 13, 2024

Conversation

mustapha-belbiad
Copy link
Contributor

Correct a small issue in the wrapper documentation :
From :

def _print_ClassName(self, stmt):
    ...
    return Y

To :

def _wrap_ClassName(self, stmt):
    ...
    return Y

@pyccel-bot
Copy link

pyccel-bot bot commented May 10, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@github-actions github-actions bot marked this pull request as draft May 10, 2024 10:09
@mustapha-belbiad
Copy link
Contributor Author

mustapha-belbiad commented May 10, 2024

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@mustapha-belbiad mustapha-belbiad marked this pull request as ready for review May 10, 2024 10:11
@pyccel-bot
Copy link

pyccel-bot bot commented May 10, 2024

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft May 10, 2024 10:12
@mustapha-belbiad mustapha-belbiad marked this pull request as ready for review May 10, 2024 10:32
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented May 10, 2024

Hey @pyccel/pyccel-dev ! @mustapha-belbiad has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team May 10, 2024 10:52
Copy link

@smazouz42 smazouz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved good job Mustapha

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed needs_initial_review labels May 10, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 10, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @mustapha-belbiad and @smazouz42 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@pyccel-bot pyccel-bot bot requested review from EmilyBourne and yguclu May 10, 2024 10:59
@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels May 12, 2024
@EmilyBourne EmilyBourne merged commit 0305011 into devel May 13, 2024
15 checks passed
@EmilyBourne EmilyBourne deleted the Correct_wrapper_docs branch May 13, 2024 08:17
EmilyBourne pushed a commit that referenced this pull request May 13, 2024
Correct a small issue in the wrapper documentation : 
From : 
```python
def _print_ClassName(self, stmt):
    ...
    return Y
```
To : 
```python
def _wrap_ClassName(self, stmt):
    ...
    return Y
```

Co-authored-by: mustapha-belbiad <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>
EmilyBourne pushed a commit to pyccel/pyccel-cuda that referenced this pull request May 14, 2024
Correct a small issue in the wrapper documentation : 
From : 
```python
def _print_ClassName(self, stmt):
    ...
    return Y
```
To : 
```python
def _wrap_ClassName(self, stmt):
    ...
    return Y
```

Co-authored-by: mustapha-belbiad <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>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants