Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct deployment target for deploy workflow (2 lines) #1872

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Correct deployment target for deploy workflow (2 lines) #1872

wants to merge 4 commits into from

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented May 13, 2024 •
edited

The deploy job does not checkout the correct branch which means that the wrong code is pushed to PyPI. This PR corrects the branch that is checked out.

@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne EmilyBourne added urgent Affects all PRs and should be merged as soon as possible next release This PR must be merged before the next release labels May 13, 2024
@EmilyBourne
Copy link
Member Author

EmilyBourne commented May 13, 2024 •
edited

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review May 13, 2024 15:40
pyccel-bot[bot]
pyccel-bot bot approved these changes May 13, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team May 13, 2024 16:00
@EmilyBourne EmilyBourne removed needs_initial_review urgent Affects all PRs and should be merged as soon as possible labels May 13, 2024
@EmilyBourne EmilyBourne marked this pull request as draft May 13, 2024 19:58
@EmilyBourne EmilyBourne marked this pull request as ready for review May 14, 2024 06:50
pyccel-bot[bot]
pyccel-bot bot approved these changes May 14, 2024
View reviewed changes
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented May 14, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@EmilyBourne EmilyBourne changed the title Correct deployment target for deploy workflow Correct deployment target for deploy workflow (2 lines) May 17, 2024
mustapha-belbiad
mustapha-belbiad approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mustapha-belbiad mustapha-belbiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed needs_initial_review labels May 20, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 20, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @mustapha-belbiad think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustapha-belbiad mustapha-belbiad mustapha-belbiad approved these changes

@pyccel-bot pyccel-bot[bot] pyccel-bot approved these changes

Assignees
No one assigned
Labels
next release This PR must be merged before the next release Ready_for_review Received at least one approval. Requires review from senior developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmilyBourne @mustapha-belbiad