Minor mod to build for custom python modules, and NVS string support #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules to be frozen, along with rules to include said modules in build.
psychogenic
changed the title
|
Also add mods to pycom module to provide support for string set/get in NVS--now we have support strings and, with e.g. JSON, basically any data structure (up to the limit of 1984 bytes supported by the ESD-IDF nvs lib). |
husigeza
reviewed
Apr 17, 2019
husigeza
reviewed
Apr 17, 2019
| } else if (ESP_ERR_NVS_INVALID_NAME == esp_err || ESP_ERR_NVS_KEY_TOO_LONG == esp_err) { | ||
| nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "invalid key (or too long)")); | ||
| } else { | ||
| // not ESP_OK, but not reporting? TODO:check this... |
There was a problem hiding this comment.
An exception here with a generic message is needed
husigeza
reviewed
Apr 17, 2019
| return mp_const_none; | ||
| } | ||
| vstr_init_len(&vstr, required_size); | ||
| if (ESP_OK != nvs_get_str(pycom_nvs_handle, key, vstr.buf, &required_size)) { |
There was a problem hiding this comment.
Instead of this, after the necessary size is fetched I would simply allocate enough byte with m_malloc(), fetch the value from NVS, then create the return object with mp_obj_new_str(), then free up the allocated memory and return the composed string. In this case it is not needed to compose vstr, remove closing \0 etc.
iwahdan88
pushed a commit
to iwahdan88/pycom-micropython-sigfox
that referenced
this pull request
May 13, 2019
iwahdan88
pushed a commit
that referenced
this pull request
May 14, 2019
…om-micropython-sigfox into psychogenic-master #226 @psychogenic
iwahdan88
pushed a commit
that referenced
this pull request
May 14, 2019
### New Features - Esp32 touchpad functionality exposed to micropy ### Improvements - Added RSA signature generation API to moducrypto - Added support for saving strings in NVS - PR #226 , author: @psychogenic - LTE class refactoring ### Bug Fix - Fix UART.sendbreak not defaulting to 13 bits as suggested by Documentation Issue #280
iwahdan88
pushed a commit
that referenced
this pull request
May 14, 2019
…thon-sigfox into psychogenic-master #226 @psychogenic # Conflicts: # esp32/frozen/Custom/README.md # esp32/mods/modpycom.c
iwahdan88
pushed a commit
that referenced
this pull request
May 14, 2019
PYFW-334: Merge and test PR #226
iwahdan88
pushed a commit
that referenced
this pull request
May 14, 2019
### New Features - Esp32 touchpad functionality exposed to micropy - Upgraded LittleFS to v2.0 (Note: this update will format the File system !! ) ### Improvements - Added RSA signature generation API to moducrypto - Added support for saving strings in NVS - PR #226 , author: @psychogenic - LTE class refactoring - BLE advertisement parameters are now configurable via MicroPython <author>: @ninoita - Added BLE raw adv data setting <author>: @ninoita ### Bug Fix - Fix UART.sendbreak not defaulting to 13 bits as suggested by Documentation Issue #280 - Fix wlan.isconnected not returning True when station is connected in AP mode Issue #244
thinkberg
pushed a commit
to ubirch/pycom-micropython-sigfox
that referenced
this pull request
May 27, 2019
thinkberg
pushed a commit
to ubirch/pycom-micropython-sigfox
that referenced
this pull request
May 27, 2019
### New Features - Esp32 touchpad functionality exposed to micropy ### Improvements - Added RSA signature generation API to moducrypto - Added support for saving strings in NVS - PR pycom#226 , author: @psychogenic - LTE class refactoring ### Bug Fix - Fix UART.sendbreak not defaulting to 13 bits as suggested by Documentation Issue pycom#280
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
…thon-sigfox into psychogenic-master pycom#226 @psychogenic # Conflicts: # esp32/frozen/Custom/README.md # esp32/mods/modpycom.c
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
PYFW-334: Merge and test PR pycom#226
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
### New Features - Esp32 touchpad functionality exposed to micropy - Upgraded LittleFS to v2.0 (Note: this update will format the File system !! ) ### Improvements - Added RSA signature generation API to moducrypto - Added support for saving strings in NVS - PR pycom#226 , author: @psychogenic - LTE class refactoring - BLE advertisement parameters are now configurable via MicroPython <author>: @ninoita - Added BLE raw adv data setting <author>: @ninoita ### Bug Fix - Fix UART.sendbreak not defaulting to 13 bits as suggested by Documentation Issue pycom#280 - Fix wlan.isconnected not returning True when station is connected in AP mode Issue pycom#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow for a standard, distinct, directory into which we can drop packages/modules to be frozen and included into the generated frozen_mpy.c