Interpolator nan handling #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 62.51% 62.69% +0.17%
==========================================
Files 33 33
Lines 1566 1568 +2
==========================================
+ Hits 979 983 +4
+ Misses 587 585 -2
Continue to review full report at Codecov.
|
|
Thanks @maxmargraf |
maxmargraf
added a commit
to maxmargraf/pycomlink
that referenced
this pull request
Nov 4, 2019
`PointsToGridInterpolator` now checks if only NaNs are passed as `z` values and returne a NaN grid in this case. Furthermore, `z` is now forced to be an array of floats because the numba IDW loop fails if integers are passed. Test for both casese were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpolator now returns nan field when provided with nan only input
interpolator can handle integer input
added two tests and fix