Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Calculate grid intersections with grid point location at lower left corner #59

Merged

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented Dec 6, 2019

Currently the calculation of grid intersections only works for grid definitions which give the center point of each grid cell. This PR adds the option to work with grids that define the lower left corner.

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   62.73%   63.27%   +0.53%     
==========================================
  Files          33       33              
  Lines        1570     1593      +23     
==========================================
+ Hits          985     1008      +23     
  Misses        585      585
Impacted Files Coverage Δ
pycomlink/validation/validator.py 57.73% <100%> (+6.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a389135...97a4158. Read the comment docs.

@cchwala cchwala merged commit a705c4f into pycomlink:master Dec 8, 2019
@cchwala cchwala deleted the add_grid_intersect_lower_left_corner branch December 8, 2019 21:20
@cchwala cchwala restored the add_grid_intersect_lower_left_corner branch October 6, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants