Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read dependencies from one file for setup.py and travis CI #81

Merged
merged 9 commits into from
May 10, 2021

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented May 10, 2021

Dependencies are in different files and are inconsistent. As suggested in #71 we read from one requirements file for travis CI and for setup.py.

Not sure what we can do for the environment.yml files.

Closes #71

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #81 (6083f4b) into master (4957a60) will increase coverage by 2.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   62.71%   65.64%   +2.92%     
==========================================
  Files          25       22       -3     
  Lines         818      780      -38     
==========================================
- Hits          513      512       -1     
+ Misses        305      268      -37     
Impacted Files Coverage Δ
pycomlink/__init__.py 100.00% <ø> (ø)
pycomlink/validation/stats.py 90.12% <0.00%> (+0.12%) ⬆️
pycomlink/validation/validator.py 57.98% <0.00%> (+0.25%) ⬆️
pycomlink/processing/xarray_wrapper.py 92.00% <0.00%> (+0.33%) ⬆️
pycomlink/processing/wet_antenna.py 86.79% <0.00%> (+0.51%) ⬆️
pycomlink/spatial/interpolator.py 75.60% <0.00%> (+0.60%) ⬆️
pycomlink/spatial/idw.py 66.07% <0.00%> (+0.61%) ⬆️
pycomlink/processing/baseline.py 19.40% <0.00%> (+1.22%) ⬆️
pycomlink/util/maintenance.py 73.33% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4957a60...6083f4b. Read the comment docs.

@cchwala cchwala changed the title Read dependencies from one file for setup and travis Read dependencies from one file for setup.py and travis CI May 10, 2021
@cchwala cchwala merged commit c115916 into pycomlink:master May 10, 2021
@cchwala cchwala deleted the streamline_dependencies branch May 10, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use joint file for dependecies
2 participants