Fix large file decompression bug #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisOrca
changed the title
rhpvorderman
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Thanks for bringing this to my attention!
On another library where I work on, pyton-isal, the ISA-L struct uses a uint32_t integer by design. I didn't properly check if this was the case for zlib-ng. My bad.
I have some minor comments. If you could address these I will make a new release ASAP.
|
Thanks a lot for your comments! Updated the PR accordingly. |
rhpvorderman
approved these changes
Apr 16, 2024
|
Release binaries are being build now. Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The ISIZE field is specified to hold the size the original (uncompressed) file modulo 2^32 (since there are only 32 bits available for this field). This means that when a file larger than 4GB is compressed,
ISIZEdoes not actually hold the file size. However, when handling the gzip trailer, the code compares the total output size with theISIZEfield directly (without truncating higher order bits), which only works ifsize_t(as the data type that is used to hold thetotal_outvariable) is also 32 bits long, which is not the case in general.