Add type hinting #143
Merged
Add type hinting #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
force-pushed
the
add-basic-type-hinting
branch
3 times, most recently
from
1674fec
to
14f19e0
Compare
FIXES pycontribs#140 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-basic-type-hinting
branch
from
14f19e0
to
35b5852
Compare
ssbarnea
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Please also add mypy to pre-commit config, without it there is no proof that mypy would pass your changes. You can inspire from https://github.com/ansible-community/ansible-lint/blob/main/.pre-commit-config.yaml#L93-L118 -- obviously depenendencies would be totally different.
Btw, thanks for taking care of this.
|
|
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
|
If you want those dependency updates in their own PR, I can move them. |
|
For the remaining type hint errors, I probably need help. I'm not as familiar with the code... |
|
And if you get #126 in first, I will happily rebase |
|
@ziegenberg I am ok with dependency version bumping but it should be done a separated pull-request. The one that adds typing (this one) should only contain changes related to typing and nothing that could affect the code at runtime. Probably you can first do the deps bumping and after we merge it you rebase this, making it clean. That is important for traceability. |
|
@ziegenberg First accept invitation from https://github.com/pycontribs/ansi2html/invitations and after that review #126 so we can merge it. I looks at it briefly and it looks ok, but I need another pair of eyes before merging that one. |
ziegenberg
force-pushed
the
add-basic-type-hinting
branch
from
70ed9c2
to
e38e371
Compare
|
So I cleaned up the branch and force pushed. Mypy still fails with wit 15 errors. I brought this number down from originally 80 but I need help with the last tricky bits. Mypy details |
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
|
Ok, I got it down to 4 errors in only one file. |
|
@ziegenberg Feel free to add |
They need to be fixed later. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-basic-type-hinting
branch
from
13f1df7
to
163b4ac
Compare
ssbarnea
approved these changes
Oct 27, 2021
ziegenberg
added a commit
to ziegenberg/ansi2html
that referenced
this pull request
Feb 6, 2022
While adding typehinting the option to specify an input encoding got ignored. This commit fixes this regression. This commit also fixes the tests with calling ansi2html as command. As the pytest documentation states, during test execution `stdin` is set to a “null” object which will fail on attempts to read from it because it is rarely desired to wait for interactive input when running automated tests. So we also patch now `sys.stdin` using a `io.TextIOWrapper` and wrapping any actual input in a `io.BytesIO`. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansi2html
that referenced
this pull request
Feb 6, 2022
While adding type-hinting the option to specify an input encoding got ignored. This commit fixes this regression. This commit also fixes the tests which call ansi2html as a command. As the pytest documentation states, during test execution `stdin` is set to a “null” object which will fail on attempts to read from it because it is rarely desired to wait for interactive input when running automated tests. So we also patch now `sys.stdin` using a `io.TextIOWrapper` and wrapping any actual input in an `io.BytesIO`. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic type hinting.
mypy ansi2html/style.pyis happy andmypy ansi2html/converter.pyspits out a few errors I don't know how to fix.Fixes: #140