Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to reduce reader research time #158

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Feb 1, 2022

@ssbarnea @echuber2 this PR addresses my own pains from understanding what "the heck" style.py is doing. I think this could save the next reader some time. What do you think?

@echuber2
Copy link
Collaborator

echuber2 commented Feb 1, 2022

Looks fine at a glance, but I've forgotten the particulars myself again, so I'll have to double-check the references tomorrow.

@ssbarnea ssbarnea added the skip-changelog Can be missed from the changelog. label Feb 1, 2022
@ssbarnea ssbarnea changed the title style.py: Add comments to reduce reader research time Add comments to reduce reader research time Feb 1, 2022
@ssbarnea ssbarnea merged commit 6daf26b into pycontribs:main Feb 1, 2022
@hartwork hartwork deleted the add-comments branch February 2, 2022 23:24
@hartwork hartwork added this to the 1.7.1 milestone Feb 17, 2022
@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request. skip-changelog Can be missed from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants