Merge branch 'coddingtonbear-allow_remotelinks_if_no_applicationlinks'

jira/client.py

@@ -928,6 +928,23 @@ def add_remote_link(self, issue, destination, globalId=None, application=None, r
             "broken: see https://bitbucket.org/bspeakmon/jira-python/issue/46 and https://jira.atlassian.com/browse/JRA-38551",
             Warning)
 
+        try:
+            applicationlinks = self.applicationlinks()
+        except JIRAError as e:
+            applicationlinks = []
+            # In many (if not most) configurations, non-admin users are
+            # not allowed to list applicationlinks; if we aren't allowed,
+            # let's let people try to add remote links anyway, we just
+            # won't be able to be quite as helpful.
+            warnings.warn(
+                "Unable to gather applicationlinks; you will not be able "
+                "to add links to remote issues: (%s) %s" % (
+                    e.status_code,
+                    e.text
+                ),
+                Warning
+            )
+
         data = {}
         if type(destination) == Issue:
 
@@ -936,7 +953,7 @@ def add_remote_link(self, issue, destination, globalId=None, application=None, r
                 'url': destination.permalink()
             }
 
-            for x in self.applicationlinks():
+            for x in applicationlinks:
                 if x['application']['displayUrl'] == destination._options['server']:
                     data['globalId'] = "appId=%s&issueId=%s" % (
                         x['application']['id'], destination.raw['id'])
@@ -958,7 +975,7 @@ def add_remote_link(self, issue, destination, globalId=None, application=None, r
             data['relationship'] = relationship
 
         # check if the link comes from one of the configured application links
-        for x in self.applicationlinks():
+        for x in applicationlinks:
             if x['application']['displayUrl'] == self._options['server']:
                 data['globalId'] = "appId=%s&issueId=%s" % (
                     x['application']['id'], destination.raw['id'])

jira/version.py

@@ -3,4 +3,4 @@
 # 1) we don't load dependencies by storing it in __init__.py
 # 2) we can import it in setup.py for the same reason
 # 3) we can import it into the jira module
-__version__ = '0.48'
+__version__ = '0.48.1'