Fix broken tests #1079
Fix broken tests #1079
Conversation
Changes: * fixed group_members() * fixed project_roles() * fixed create_board() * fixed # tests, new tests result: 165 passed, 4 xfailed, 1 skipped test_dashboard.py: 2 xfailed test_security_level.py: 2 xfailed test_service_desk.py: 1 skipped there 5 cases are expected, they are all because of the standalone jira instance from the docker image has no these data defined by default. To make them pass, need to create dashboard or security schema, unfortunately, there is no REST API to create them.
There was a problem hiding this comment.
While I was ready to give a super +++ for fixing the broken tests, once I started to look at the review I see that this changes does a considerably number of changes to the library itself, including its public APIs!
I do not know the reasons behind those changes but I know for sure that they should not be allowed to go inside as part of of a change named "fix broken tests". The impact on users would be huge.
Probably we should keep this open and gradually make PRs for things that are clear, also lowering its size once those merge.
ssbarnea
added
the
Status: Blocked
Some of the changes to the library itself is about parameter name changes, I can certainly keep them back compatible. While some of the changes is because the APIs are broken on JIRA Server 8.9.0 (such as create_board() requests 'filterId' instead of 'project_ids'), I'm sure they worked on some version of JIRA Server. I agree we should not let the users down, probably we need to set up tests infrastructures for various JIRA versions and run the tests against all of them, just like what you guys have did against py36/37/38/39. I'm not sure whether it's feasible to create docker images for different JIRA Server versions, does anyone has dock image experiences know about this? |
Revert most of changes made in the library itself. With this change, 1 more test xfailed: tests/resources/test_issue.py::IssueTests::test_agile, this fail is because GreenHopper returns error when creating sprint on standalone jira docker image. Latest tests results: 164 passed, 6 xfailed, 1 skipped
| @@ -1232,7 +1232,17 @@ def group_members(self, group: str) -> OrderedDict: | |||
|
|
|||
| result = {} | |||
| for user in r["users"]["items"]: | |||
| result[user["id"]] = { | |||
| # 'id' is likely available only in older JIRA Server, it's not available on newer JIRA Server. | |||
There was a problem hiding this comment.
Honestly, looking at the existing docs I have no idea how long since they removed id . I looked as far back as v6.0.1 for Jira Server and it still didn't have an id property for the returned users.
We can also see that the group endpoint is Deprecated, group/member is suggested instead (which will allow us to remove the legacy pagination in this function).
https://docs.atlassian.com/software/jira/docs/api/REST/8.13.6/#api/2/group-getUsersFromGroup
https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-groups/#api-rest-api-2-group-get
Let's make a separate PR to deal with this, there we may remove hasId and instead have something like:
result[user.get("accountId", user.get("name"))] =
I like the idea but definitely think we are a while off from reaching that point. I think the order to spend our effort might look like:
|
adehad
added
Status: Ready for Merge
* fixed tests Changes: * fixed group_members() * fixed project_roles() * fixed create_board() * fixed # tests, new tests result: 165 passed, 4 xfailed, 1 skipped test_dashboard.py: 2 xfailed test_security_level.py: 2 xfailed test_service_desk.py: 1 skipped there 5 cases are expected, they are all because of the standalone jira instance from the docker image has no these data defined by default. To make them pass, need to create dashboard or security schema, unfortunately, there is no REST API to create them. * Fixed review issues Revert most of changes made in the library itself. With this change, 1 more test xfailed: tests/resources/test_issue.py::IssueTests::test_agile, this fail is because GreenHopper returns error when creating sprint on standalone jira docker image. Latest tests results: 164 passed, 6 xfailed, 1 skipped
Changes:
test_dashboard.py: 1 test == 2 xfailed
test_security_level.py: 1 test == 2 xfailed
test_service_desk.py: 1 test skipped
there 3 tests are expected, they are all because of the standalone jira instance from the docker image has no these data defined by default. To make them pass, we need to create dashboard or security schema, unfortunately, there is no REST API to create them.