Allow _get_user_accountid to find "Unassigned" and "Automatic" users. #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return None, -1, and "-1" back from _get_user_accountid to allow `assign_issue` to do that as well. Co-Authored-By: Byron Peebles <17276623+truthbyron@users.noreply.github.com>
Co-Authored-By: pari <57524256+patrick-ringl-by@users.noreply.github.com>
adehad
force-pushed
the
bugfix/support_unassigned_and_automatic
branch
from
ec669f0
to
07347ec
Compare
This was referenced Sep 18, 2021
studioj
reviewed
Oct 17, 2021
| @@ -162,6 +162,10 @@ Reassign an issue:: | |||
| # requires issue assign permission, which is different from issue editing permission! | |||
| jira.assign_issue(issue, 'newassignee') | |||
|
|
|||
| If you want to unassign it again, just do:: | |||
|
|
|||
| jira.assign_issue(issue, None) | |||
There was a problem hiding this comment.
would it make sense to clarify it has a return value?
There was a problem hiding this comment.
I see the examples as more of a quick-start guide, that can help someone understand what features are available, with the function docstrings being the ground truth that explain the full syntax of how the function should be called and the return types.
That said, there should be a link to the function definition in the docs. I'll make a separate PR with that in
studioj
approved these changes
Oct 17, 2021
adehad
changed the title
svermeulen
pushed a commit
to svermeulen/jira
that referenced
this pull request
Oct 31, 2021
…pycontribs#1152) Return None, -1, and "-1" back from _get_user_accountid to allow `assign_issue` to do that as well. Co-authored-by: Byron Peebles <17276623+truthbyron@users.noreply.github.com> Co-authored-by: pari <patrick.ringl@blueyonder.com> Co-authored-by: pari <57524256+patrick-ringl-by@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #902 , #1088