add the .verify property correctly
#1202
Conversation
jira/client.py
Outdated
| @@ -3403,6 +3395,13 @@ def _add_client_cert_to_session(self): | |||
| client_cert: Tuple[str, str] = self._options["client_cert"] # to help mypy | |||
| self._session.cert = client_cert | |||
|
|
|||
| def _add_ssl_cert_to_session(self): | |||
| """ | |||
| Adds the client certificate to the request if configured through the constructor. | |||
There was a problem hiding this comment.
Is this adding the client certificate, or the certificate authority?
There was a problem hiding this comment.
Thanks, this was a copy paste job I failed to update. I've now updated both the name of the function and improved the docstring for clarity.
Yeah I have no idea how to test this, really the |
:-) see it as a challenge :D you have my approval... |
😆 |
* add the `.verify` property correctly * remove duplicated line updating the cookies of the session * update docstrings and function name for clarity * update client `__init__` docstring, as that is actually public
Addressed the concerns raised by #339
http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification
pip install git+https://github.com/pycontribs/jira.git@bugfix/correctly_add_ssl_cert