Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use importlib.metadata instead of pkg_resources #1359

Merged
merged 2 commits into from Apr 16, 2022
Merged

use importlib.metadata instead of pkg_resources #1359

merged 2 commits into from Apr 16, 2022

Conversation

adehad
Copy link
Collaborator

@adehad adehad commented Apr 15, 2022 •
edited

Summary of Changes

  1. Remove pkg_resources to set __version__ instead using importlib.metadata
  2. Remove pkg_resources wrapper for parsing version, and directly use packaging (note: comes with setuptools install, but added to requirements for completeness)

Closes #1248

@adehad adehad temporarily deployed to cloud April 15, 2022 01:16 Inactive
@adehad adehad added the feature label Apr 15, 2022
@adehad adehad linked an issue Apr 15, 2022 that may be closed by this pull request
Usage of pkg_resources slows down imports #1248
Closed
4 tasks
@adehad
Copy link
Collaborator Author

adehad commented Apr 15, 2022

@vkomarov-r7 @3V3RYONE can you give this a review and see if this meets your expectations?

@adehad adehad requested a review from studioj April 15, 2022 10:39
@adehad adehad temporarily deployed to cloud April 15, 2022 10:45 Inactive
3V3RYONE
3V3RYONE reviewed Apr 16, 2022
View reviewed changes
Copy link

@3V3RYONE 3V3RYONE left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @adehad !! The changes make sense, nice work!

@adehad adehad merged commit 39a74e5 into main Apr 16, 2022
@adehad adehad deleted the feature/remove_pkg_resources_use branch April 16, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3V3RYONE 3V3RYONE 3V3RYONE left review comments

@studioj studioj Awaiting requested review from studioj

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of pkg_resources slows down imports
2 participants
@adehad @3V3RYONE