Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated jira.search_issues default behaviour to include all fields #1360

Merged
merged 4 commits into from Apr 18, 2022

Conversation

Yusuf-TJ
Copy link
Contributor

The jira.search_issues documentation states that when nothing is passed to the field parameter, all fields are returned.
https://jira.readthedocs.io/api.html?highlight=search_issues#jira.client.JIRA.search_issues
The "*all" has been set as the default field parameter to achieve this.

Same fix as #1354
Resolves #1240

The `jira.search_issues` documentation states that when nothing is passed to the field parameter, all fields are returned.
https://jira.readthedocs.io/api.html?highlight=search_issues#jira.client.JIRA.search_issues
The "*all" has been set as the default field parameter to achieve this.
@adehad adehad added the feature label Apr 16, 2022
Copy link
Collaborator

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, let's get some tests in!

@adehad
Copy link
Collaborator

adehad commented Apr 16, 2022

@Yusuf-TJ Let's re-use this same pull request, easier to keep track of review comments and whether they have been addressed or not.

@Yusuf-TJ Yusuf-TJ marked this pull request as draft April 18, 2022 16:24
Copy link
Collaborator

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few minor changes, but really like the test cases!

tests/resources/test_issue.py Outdated Show resolved Hide resolved
@adehad adehad marked this pull request as ready for review April 18, 2022 19:52
Copy link
Collaborator

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@adehad adehad changed the title updated jira.search_issues default behaviour updated jira.search_issues default behaviour to include all fields Apr 18, 2022
@adehad adehad merged commit bf29a93 into pycontribs:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search_issue does not return the comments field.
2 participants