-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy ResilientSession implementation #1366
Conversation
ccc921b
to
febf197
Compare
febf197
to
6985a6f
Compare
@StefanoBoriero , could I bother you to have a look at this? As you were recently in this code I thought you might be able to critique this ! |
With pleasure! I'll find some time in the next few days to do so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements! I left some comments mostly about refactoring, let me know what you think
b4ed5dc
to
a33aceb
Compare
Thanks @StefanoBoriero, I've tried to address most of the concerns, with some discussions points. I've organised my commits to tackle individual comments (as GitHub a bit weird this way) and left it up to you to resolve threads that I've addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite a lengthy PR ... I'd like to test this out before giving my "official" approval :) I'll try to do so this week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rework looks ok and the code is covered in the functional tests ... only the extra doc still todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @studioj , I'll make some time to finish the PR
e8fb1c7
to
57c6357
Compare
57c6357
to
3c217dd
Compare
Summary of Changes
MultipartEncoder
scheme for attachmentsTODO
Special Thanks:
@datashaman : https://stackoverflow.com/questions/23267409/how-to-implement-retry-mechanism-into-python-requests-library/23271433#comment58969710_23271433