Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement SHA fallback behaviour #1678

Merged
merged 5 commits into from Jun 29, 2023
Merged

implement SHA fallback behaviour #1678

merged 5 commits into from Jun 29, 2023

Conversation

adehad
Copy link
Collaborator

@adehad adehad commented Jun 6, 2023 •
edited

Summary of changes

  1. try multiple SHAs with OAuth1, going from: user choice, most secure default, known working fallback
  • should try and get some tests
  • need to confirm behaviour of RHEL

@adehad adehad linked an issue Jun 6, 2023 that may be closed by this pull request
signature_method_rejected returned with 3.5.1 but not 3.5.0 #1677
Closed
4 tasks
@adehad adehad added the bug label Jun 6, 2023
@adehad adehad temporarily deployed to cloud June 6, 2023 20:23 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to cloud June 26, 2023 22:52 Inactive
@adehad adehad force-pushed the bugfix/default_oauth1_sha branch from decbe7b to dd4c12d Compare June 28, 2023 22:45
@adehad adehad merged commit 93eb05f into main Jun 29, 2023
12 checks passed
@adehad adehad deleted the bugfix/default_oauth1_sha branch June 29, 2023 10:44
@brooookemiller brooookemiller mentioned this pull request Dec 13, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signature_method_rejected returned with 3.5.1 but not 3.5.0
1 participant
@adehad