Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use field translation in Jira.issue method #1864

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Wojtini
Copy link

@Wojtini Wojtini commented May 28, 2024

Fields param in issue are untranslated so if you use custom_field's name instead of id Jira API won't return it. Those changes are supposed to fix that.

Changes:

  1. Extracted translation part to seperate methods
  2. Changed variable names to be less abraviated
  3. Reused those methods in Issue method
  4. Missing tests for limiting fields on Issue method
  5. Seperate tests for translation (Added duedate field to test issue)

To Do: Squash commits before merge

@Wojtini Wojtini changed the title Use field translation in Jira.issue method Draft: Use field translation in Jira.issue method May 29, 2024
@Wojtini Wojtini changed the title Draft: Use field translation in Jira.issue method fix: Use field translation in Jira.issue method May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant