-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jira ServiceDesk support #371
Conversation
…edesk_info, create organization, delete_organization + tests.
…service-desk-and-internal-comments
…desk Add support for some Service Desk API calls
…rom Server version API.
Codecov Report
@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
+ Coverage 47.94% 50.09% +2.14%
===========================================
Files 10 10
Lines 2484 2651 +167
Branches 461 492 +31
===========================================
+ Hits 1191 1328 +137
- Misses 1150 1153 +3
- Partials 143 170 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adding a lot of code to a class that is already really big and i am wondering if it would not worth to add a Desk class which exposes its instance automatically as "desk" attribute on Jira() objects. So people will be able to do j.desk.create_case()
instead of "j.create_case".
This will keep the namespace clear and also allow you to put all the code related to desk in a separate file.
Please do not start to implement these changes until we don't get some feedback from someone else. Maybe they have better ideas.
Definitely agree with @ssbarnea that it would be a good idea to segregate this code off to prevent the JIRA class growing too monolithic. This seems like a separate area of functionality and a nice boundary on which to segregate. |
Closing this work needs to be rebased on master. Please feel free to create new PR, preferably splitting the work in multiple ones. It would be much easier to get small reviews in than bigger ones. |
Added following API methods support (it doesn't break previously added methods):
All method covered with tests.