Fix JIRAError to correctly include full details #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str(JIRAError) now includes full details of any server-side errors. The problems in the __str__ implementation are threefold: 1. The response.text block checks for the text attribute but then uses the headers attribute (cut-and-paste error from the lines above) 2. The response object is "Truthy" based upon the HTTP response, so in the case of an HTTP error it is actually "False" so the conditional check fails and response details are not included. 3. Finally, the format string is invalid and causes an exception because it is missing a %s at the end. These problems have all been addressed in this commit.
ssbarnea
added a commit
that referenced
this pull request
Jul 15, 2015
Fix JIRAError to correctly include full details
ssbarnea
added a commit
that referenced
this pull request
Nov 21, 2016
Fix JIRAError to correctly include full details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #85
str(JIRAError) now includes full details of any server-side errors.
The problems in the str implementation are threefold:
the headers attribute (cut-and-paste error from the lines above)
the case of an HTTP error it is actually "False" so the conditional
check fails and response details are not included.
because it is missing a %s at the end.
These problems have all been addressed in this commit.