Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the file descriptor for add_attachment #957

Merged
merged 4 commits into from
May 18, 2021
Merged

Close the file descriptor for add_attachment #957

merged 4 commits into from
May 18, 2021

Commits on May 16, 2021

  1. Close the file descriptor for add_attachment 

    If the attachment is string, the add_attachment function creates a
file descriptor then forget to close it. The patch closes the file
descriptor after the post action.
    @yen3
    yen3 committed May 16, 2021
    Configuration menu
    Copy the full SHA
    7cc6c96 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Pass a correct type for the variable

    @yen3
    yen3 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    6da708b View commit details
    Browse the repository at this point in the history

  2. Convert type earliy

    @yen3
    yen3 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    c40e9a4 View commit details
    Browse the repository at this point in the history

  3. Refine code format

    @yen3
    yen3 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    c2b42d2 View commit details
    Browse the repository at this point in the history